Review requested:

• @nodejs/security-wg

CI: https://ci.nodejs.org/job/node-test-pull-request/71354/

There seems to be a related failure on Windows:

stack: |-
  node:internal/assert/utils:146
    throw error;
    ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  + actual - expected

  + 'write EPIPE'
  - 'write EBADF'
            ^

      at Socket.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-net-socket-write-after-close.js:15:16)
      at Socket.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:507:15)
      at Socket.emit (node:events:508:20)
      at emitErrorNT (node:internal/streams/destroy:170:8)
      at emitErrorCloseNT (node:internal/streams/destroy:129:3)
      at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: 'write EPIPE',
    expected: 'write EBADF',
    operator: 'strictEqual',
    diff: 'simple'
  }

  Node.js v26.0.0-pre

I've taken a look at this. First of all, both native and JS tests (some other than the one mentioned in a previous comment) failed, so I reran the 2 jobs (native, JS), and the only failure left is the one from parallel.test-net-socket-write-after-close.

The reason for the failure seems to be the change from this PR. I do not know how the others feel, but for me personally, changing the expected behavior to a new error doesn't seem like a big issue and I'd go with that approach. Of course, I leave the option that there is something that would not allow this that I'm not aware of, so if there is, please let me know.

Hey all, just wanted to ping here again about the Windows test failure and my suggestion to fix it - changing the error we expect in the test. If there are some objections to that approach, please let me know. Otherwise, I'll push the change to the test on Thursday/Friday this week.